Log candidate_hash and pov_hash for expired collations
#9927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sajjon
added
the
R0-no-crate-publish-required
alexggh
approved these changes
Oct 3, 2025
sandreim
approved these changes
Oct 3, 2025
Sajjon
added
T0-node
|
/cmd prdoc --audience node --bump patch |
|
Command "prdoc --audience node --bump patch" has failed ❌! See logs here |
Sajjon
deleted the
cyon/log_candidate_hash_and_pov_hash_when_collations_expire
branch
alvicsam
pushed a commit
that referenced
this pull request
Oct 17, 2025
When collations expire we do not log the `candidate_hash` nor the `pov_hash` making it hard to map the logged entries about `Candidate generated` and `Candidate expired` together. # Changes I've added `pov_hash` and `candidate_hash` to the `CollationStats` struct and logging these fields when we log `"Collation expired"` # Compatability I'm unsure of the label to use. `CollationStats` is only `pub(crate)` and we only create them in the place I used, the constructor is only used in one place, the place where I changed. ([Matrix thread](https://matrix.to/#/!oRmZcZCtnViqLdLelR:parity.io/$Xwm4WDbOAkJD_tdf8ksLUu81bLoDbZxUu2b46_RJ_7k?via=parity.io))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When collations expire we do not log the
candidate_hashnor thepov_hashmaking it hard to map the logged entries aboutCandidate generatedandCandidate expiredtogether.Changes
I've added
pov_hashandcandidate_hashto theCollationStatsstruct and logging these fields when we log"Collation expired"Compatability
I'm unsure of the label to use.
CollationStatsis onlypub(crate)and we only create them in the place I used, the constructor is only used in one place, the place where I changed.(Matrix thread)